Skip to content

Conversation

@NEOatNHNG
Copy link

The recommended place to install completions to is the BASH_COMPLETION_USER_DIR which loads completions on demand.

The recommended place to install completions to is the BASH_COMPLETION_USER_DIR which loads completions on demand.
@google-cla
Copy link

google-cla bot commented Oct 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@meteorcloudy meteorcloudy requested a review from Copilot October 7, 2025 15:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the bash completion installation instructions to use the standard BASH_COMPLETION_USER_DIR location instead of a generic filename. This follows bash completion best practices by installing completions into the user-specific completion directory where they are loaded automatically on demand.

  • Modified completion script installation to use BASH_COMPLETION_USER_DIR with XDG fallback
  • Added directory creation command to ensure the completion directory exists
  • Changed output filename from generic "bash-complete.bash" to specific "bazel.bash"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant