perf: skip comment assignment when no comments exist#1473
Open
jbedard wants to merge 2 commits into
Open
Conversation
assignComments calls order() which walks the entire tree appending every expression to the preorder/postorder lists used only to attach comments. When the file has no comments this work (and its allocation) is wasted, so return early.
order() builds both the preorder and postorder lists, but the preorder list is only consumed when attaching line comments and the postorder list only when attaching suffix comments. Build each list only when a comment of that kind is present, so a file with only one kind of comment no longer allocates the unused list.
Contributor
There was a problem hiding this comment.
Code Review
This pull request optimizes the comment assignment process in build/lex.go by skipping the AST traversal in assignComments if there are no line or suffix comments. It also conditionally populates the preorder and postorder lists in order only when the respective comment types are present. No review comments were provided, and I have no feedback to offer.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a large repo this made a minor difference in memory consumption on gazelle invocations. This is minor enough it may not be worth it, or maybe only the first commit is worth the extra code.
The first commit is simpler and has the largest gain in my large repo, but doesn't cover as wide of a range of cases.
Robot summary of results:
Buildtools PR checklist
Description
assignCommentspreviously walked the full syntax tree on every parse, building preorder and postorder node lists used to attach line and suffix comments.This change skips the walking and
pre/postconstruction when no comments exists.(optional) These changes were tested using the following steps
bazel tests, patching the go.mod when invoking gazelle in a large repo while profiling memory/GC