Sync Outdated Terraform Buildkite Pipelines for bazel-testing Org#2465
Open
Sync Outdated Terraform Buildkite Pipelines for bazel-testing Org#2465
Conversation
1. Updated Buildkite provider version 2. Imported existing pipelines 3. Better formatting 4. Updated docker ubuntu version
SalmaSamy
requested review from
Wyverald,
fweikert and
meteorcloudy
as code owners
fweikert
requested changes
Feb 10, 2026
Member
fweikert
left a comment
fweikert
left a comment
There was a problem hiding this comment.
- Can you please update the description to mention that this only covers the testing org?
- Something is wrong - I see 32 pipelines in the testing org, but only 24 in the Terraform config
- Nit: Which command did you use to sync the files? It would be nice to include that in the description
Contributor
Author
Description updated. |
SalmaSamy
commented
Feb 10, 2026
| ---%{ if length(envs) > 0 } | ||
| env:%{ for key, value in envs } | ||
| ${key}: "${value}"%{ endfor ~} | ||
| ${key}: ${key == "LC_ALL" ? value : jsonencode(value)}%{ endfor ~} |
Contributor
Author
There was a problem hiding this comment.
@fweikert not sure if this is the best way to do this, but this is the only var that should have unquoted value. WDYT?
Member
There was a problem hiding this comment.
Which values do actually need json encoding? I see others that don't (e.g. ENABLE_BAZELISK_MIGRATE).
Re-enabling buildfarm in the downstream pipeline now that the infrastructure is stable and passing
We haven't used them since migrating from physical machines to hosted VMs, and their continued existence only leads to confusion (e.g. #2466).
- Fix debian 13 by avoid using software-properties-common (removed in debian 13) - Added a helper function in build.sh to reduce log size - Surface build error by waiting on specific PID. Fixes #2459 (comment)
SalmaSamy
changed the title
This changes allow terraform changes to be managed by github. Once a pull request is made a plan should be generated Once a pull request is merged the plan will be applied
1. Updated Buildkite provider version 2. Imported existing pipelines 3. Better formatting 4. Updated docker ubuntu version
…om/bazelbuild/continuous-integration into Update-terraform-for-bazel-testing
SalmaSamy
had a problem deploying
to
bazel-testing
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync terraform files for: bazel-testing org
Used -generate-config-outterraform flag + script to pull and set provider settings (the generate import doesn't pull them by default)