Open
Conversation
Contributor
SalmaSamy
commented
Mar 2, 2026
SalmaSamy
commented
- Fix error in _open_url: seperated the logic for open_url and open_with_paganation
- Used BuildkiteClient tokens instead of env tokens
…ntinuous-integration into fix-metrics-poller
SalmaSamy
requested review from
Wyverald,
fweikert and
meteorcloudy
as code owners
fweikert
requested changes
Mar 2, 2026
buildkite/bazelci.py
Outdated
| """Returns the decode utf-8 representation of the _get_url_response.""" | ||
| return self._get_url_response(url, params, retries).read().decode("utf-8", "ignore") | ||
|
|
||
| def _open_url_with_paganation(self, url, params=[], retries=5) -> List: |
Member
There was a problem hiding this comment.
I think we should update the names of the methods to make it clear that one fetches text vs the other paginated json objects
Contributor
Author
There was a problem hiding this comment.
Check the new names and tell me what you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.