buildkite: handle matrix attributes in unexpected locations#2487
Open
novas0x2a wants to merge 1 commit intobazelbuild:masterfrom
Open
buildkite: handle matrix attributes in unexpected locations#2487novas0x2a wants to merge 1 commit intobazelbuild:masterfrom
novas0x2a wants to merge 1 commit intobazelbuild:masterfrom
Conversation
novas0x2a
requested review from
Wyverald,
fweikert and
meteorcloudy
as code owners
novas0x2a
force-pushed
the
fix-matrix-dict
branch
from
a74077f to
69a0e78
Compare
soft_fail contains a list of dicts, and the matrix processing was seeing it and getting confused. This change makes lists and dicts get processed all the way down, and also completely ignores data types it doesn't know how to process, rather than blowing up on them. Fixes bazelbuild#2486
novas0x2a
force-pushed
the
fix-matrix-dict
branch
from
69a0e78 to
1e6a04c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
soft_fail contains a list of dicts, and the matrix processing was seeing it and getting confused. This change makes lists and dicts get processed all the way down, and also completely ignores data types it doesn't know how to process, rather than blowing up on them.
Fixes #2486