chore(deps): update maven dependencies#8216
chore(deps): update maven dependencies#8216LeFrosch wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine maintenance task: updating various Maven dependencies to their newer versions. The changes ensure that the project utilizes the latest features, bug fixes, and performance improvements from libraries such as Mockito, Objenesis, and the Kotlin standard and serialization libraries. The Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates several Maven dependencies. The changes are mostly straightforward version bumps. I've found one area for improvement regarding the version of kotlin-stdlib. It's being updated to 2.2.21, but rules_kotlin is at 2.3.0, which forces a conflict resolution. I've suggested aligning the kotlin-stdlib version to 2.3.0 for consistency and to simplify the build configuration.
| # Only required for the maintenance script, otherwise use the stdlib for the sdk | ||
| "org.jetbrains.kotlin:kotlin-stdlib:2.1.21", | ||
| "org.jetbrains.kotlinx:kotlinx-serialization-json:1.8.0", | ||
| "org.jetbrains.kotlin:kotlin-stdlib:2.2.21", |
There was a problem hiding this comment.
The rules_kotlin dependency is at version 2.3.0 in this file (line 37). To maintain consistency and simplify dependency resolution, it's better to align the kotlin-stdlib version with it. This will also remove the need for the conflict_resolution entry that was added to maven_install.json.
| "org.jetbrains.kotlin:kotlin-stdlib:2.2.21", | |
| "org.jetbrains.kotlin:kotlin-stdlib:2.3.0", |
Nothing interesting here :)