Skip to content

Fix toolchain resolution for the new aspect#8394

Draft
LeFrosch wants to merge 3 commits into
bazelbuild:masterfrom
LeFrosch:pull/d7033417d316933b5bdbb7e6ea5639e522891319
Draft

Fix toolchain resolution for the new aspect#8394
LeFrosch wants to merge 3 commits into
bazelbuild:masterfrom
LeFrosch:pull/d7033417d316933b5bdbb7e6ea5639e522891319

Conversation

@LeFrosch

@LeFrosch LeFrosch commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

The new aspect reports toolchains under a dedicated dependency type, which should be preferred over toolchains from the regular dependencies.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors toolchain dependency resolution, improves target key formatting, and adds click actions to issue outputs. Specifically, it introduces a presentable() method on TargetKey, adds a withOnClick handler to IssueOutput, and refactors BlazeConfigurationToolchainResolver to filter toolchain dependencies by type and provide more detailed warnings. Feedback on these changes highlights two key issues: first, using findFirst() when resolving toolchains bypasses validation for multiple toolchain dependencies; second, appending (missing) for empty configurations on plain targets is misleading and should be avoided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread cpp/src/com/google/idea/blaze/cpp/BlazeConfigurationToolchainResolver.java Outdated
Comment thread base/src/com/google/idea/blaze/base/ideinfo/TargetKey.java
@LeFrosch LeFrosch force-pushed the pull/d7033417d316933b5bdbb7e6ea5639e522891319 branch from e5a356e to 4e6114d Compare July 9, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant