Fix readStreamedRetried retry in bytestream #619
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix readStreamedRetried in rbe bytestream Transient errors are retried by `readStreamedRetried` and it continues reading from how many bytes were already read. When an error happens in the stream call (for example, `DeadlineExceeded`), we were returning that 0 bytes were read. Since `DeadlineExceeded` is transient, the retry happens and we start from byte 0 again, leading to a lot of duplication. Note that the other errors return a `fmt.Errorf`, which is not a transient error and won't be retried. The current behavior seems to be only working to retry at the start of the stream, when no bytes were there yet.
bentekkie
approved these changes
May 7, 2025
uillianluiz
added a commit
to uillianluiz/remote-apis-sdks
that referenced
this pull request
May 15, 2025
* Fix readStreamedRetried retry in bytestream (bazelbuild#619) Fix readStreamedRetried in rbe bytestream Transient errors are retried by `readStreamedRetried` and it continues reading from how many bytes were already read. When an error happens in the stream call (for example, `DeadlineExceeded`), we were returning that 0 bytes were read. Since `DeadlineExceeded` is transient, the retry happens and we start from byte 0 again, leading to a lot of duplication. Note that the other errors return a `fmt.Errorf`, which is not a transient error and won't be retried. The current behavior seems to be only working to retry at the start of the stream, when no bytes were there yet. * Fix bug in handling of expiry buffer. (bazelbuild#620) * update flatten action outputs to consider OutputSymlinks OutputSymlinks is the non-deprecated way to provide symlinks, but not handled in the FlattenActionOutputs. * Update test to account outputsymlink --------- Co-authored-by: ramymedhat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transient errors are retried by
readStreamedRetriedand it continues reading from how many bytes were already read. When an error happens in the stream call (for example,DeadlineExceeded), we were returning that 0 bytes were read.Since
DeadlineExceededis transient, the retry happens and we start from byte 0 again, leading to a lot of duplication.Note that the other errors return a
fmt.Errorf, which is not a transient error and won't be retried.The current behavior seems to be only working to retry at the start of the stream, when no bytes were there yet.