Update bazel verison #629
Merged
Update bazel verison #629
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywmei-brt1
force-pushed
the
break-a-test-case
branch
2 times, most recently
from
177d68b to
20355c3
Compare
ywmei-brt1
changed the title
ywmei-brt1
force-pushed
the
break-a-test-case
branch
2 times, most recently
from
f64b375 to
c7a27e4
Compare
To open this project with GoLand + bazel plugin, the min version of bazel we need is 6.0.0. There is a race condition in the test that `batch_retries_test.go` cannot run together with the rest of the test files. This CL fix add a lock to fix the race condition. add "exclusive" bazel tag to not run client_test with other bazel test targets, and add an arg `-test.parallel=1` to make go run all the test case under client_test one by one. Test: run bazelisk test //... --test_output=streamed --flaky_test_attempts=1 on my cloudtop Bug: NA
ywmei-brt1
force-pushed
the
break-a-test-case
branch
from
c7a27e4 to
1d7f861
Compare
fangism
approved these changes
Aug 15, 2025
fangism
left a comment
fangism
left a comment
There was a problem hiding this comment.
I can confirm, bazel test ... passes with this change.
Closed
gkousik
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.