Prevent downloaded files escape from outDir #634
Merged
+185
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional file path check to make sure all the downloaded files will be under the outDir. Any attempt of escaping the outDir will fail the download. This is a breaking change though, note that the TestDownloadActionOutputs test has been updated to avoid break. Bug: b/460031498 Test: Unit test updated.
gkousik
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional file path check to make sure all the downloaded files will be under the outDir.
Any attempt of escaping the outDir will fail the download.
This is a breaking change though (note that the TestDownloadActionOutputs test has been updated, download file out of outDir is not supported anymore).
Bug: b/460031498
Test: Unit test updated.