Skip to content

Remove no-remote when there aren’t any codesign commands #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apple/internal/processor.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,9 @@ def _bundle_partial_outputs_files(
"no-sandbox": "1",
}

if platform_prerequisites.platform.is_device and provisioning_profile:
if (codesigning_command and
platform_prerequisites.platform.is_device and
provisioning_profile):
# Added so that the output of this action is not cached remotely,
# in case multiple developers sign the same artifact with different
# identities.
Expand Down