Fix permissions when openrsync is used #2708
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjburghard
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
mjburghard
commented
May 9, 2025
| rsync_command = [ | ||
| "/usr/bin/rsync", | ||
| "--archive", | ||
| "--delete", | ||
| "--checksum", | ||
| "--chmod=u+w", | ||
| "--perms", |
There was a problem hiding this comment.
Adding --perms since the man page says it is required when passing --chmod.
Does not have any observable effect at the moment.
mjburghard
force-pushed
the
fix-rsync-permissions
branch
from
2bf6805 to
9e19934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix file permissions when
openrsyncis used on macOS 14.5+.What was changed
Apply write permission using
find&chmodwhen running on macOS 14.5+. To mitigate any previousbazel runinvocations that already left the temporary directory without write permissions, an additional check and call to fix the permissions is added before callingrsync. This is needed whenrsyncneeds to delete or modify any existing files.Why was this changed
macOS 15.4.1 replaced the rsync implementation with openrsync. Apple seems to have added some additional flags like
--chmodto openrsync to match the functionality and interface of rsync. Unfortunately, not there are bugs like--chmodbeing not properly applied when syncing directories.How to test
bazelisk run //examples/ios/HelloWorld --define=apple.experimental.tree_artifact_outputs=1.simctlshould fail with a permission error. (If this steps succeeds, delete the temporary directory and uninstall HelloWorld from the iOS simulator).