Add requires_not_none support for cc_args.env #484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this commit bazelbuild@5a8cab7 bazel has supported expand_if_available for env_sets. This is useful when it's easier in the tool being run to accept optional arguments via environment variables vs potentially double parsing and filtering arguments. For example in the case of parse_headers actions you either have to parse the command line (including optional response files) in order to find the value passed to `-o`, or you can organize it so you can read it from the environment instead with this.
keith
requested review from
armandomontanez,
c-mita,
comius,
hvadehra,
pzembrod and
trybka
as code owners
Member
Author
Member
Author
|
an example of this type of change in an old style toolchain bazelbuild/apple_support#429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this commit
5a8cab7
bazel has supported expand_if_available for env_sets. This is useful
when it's easier in the tool being run to accept optional arguments via
environment variables vs potentially double parsing and filtering
arguments.
For example in the case of parse_headers actions you either have to
parse the command line (including optional response files) in order to
find the value passed to
-o, or you can organize it so you can readit from the environment instead with this.