Remove allowlist_include_directories from data #535
+44
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When very recent versions of bazel, improvements in the merkle tree
recommend that instead of passing a huge list of files to the toolchain,
you instead pass the root directory of those files once, and then bazel
symlinks the entire directory as opposed to every file one by one. In
order to do this you must pass a filegroup pointing at only the
directory. In this case, if you then also pass all the files, you get
conflicts in bazel trying to link the files, and the directory. If you
didn't get those conflicts you would still lose the perf benefits.
This change makes allowlist_include_directories only affect the
cxx_builtin_include_directories field. If you need the directory also in
data, you must now also add it to
data. If you want to continue usingthe entire list of files, that still works fine.