Move to the official bazel worker api (with workspace support) #1400
Conversation
# Conflicts: # MODULE.bazel
Implements workspace_compat.bzl to enable bazel-worker-api usage in WORKSPACE mode, similar to rules_scala's approach but supporting both proto and java components. Changes: - Created workspace_compat.bzl to download bazel_worker_api and bazel_worker_java from GitHub releases - Updated setup.bzl to add required Maven dependencies (gson, error_prone_annotations) and upgrade guava to 33.0.0-jre - Updated versions.bzl with BAZEL_WORKER_API version constant - Modified initialize.bzl to call workspace_compat() in kotlin_repositories() - Synchronized MODULE.bazel dependencies with WORKSPACE setup - Repinned Maven dependencies This allows PR bazelbuild#1218 to work with both bzlmod and WORKSPACE builds.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
agluszak
changed the base branch from
move-to-the-official-bazel-worker-api
to
master
Add missing worker_protocol_java_proto dependency to WorkerEnvironment test library and expose visibility for test package access. Fixes compilation error where WorkerEnvironment.kt couldn't resolve WorkRequest and WorkResponse classes from the worker protocol.
agluszak
changed the title
|
For context behind why I never merged the worker API changes - The worker impl. that Google released only supports Bzlmod and does not support workspace files, so we'd have to maintain that scaffolding ourselves until we decide to fully cut WORKSPACE support (we can have that discussion). Didn't seem worth it to make local development and external developer overrides more complicated for our remaining WORKSPACE users with not much actual benefit. |
2 participants
Continuation of #1218