Fix stamping for rules that don't have a stamp attribute#3829
Merged
krasimirgg merged 9 commits intobazelbuild:mainfrom Jan 29, 2026
Merged
Fix stamping for rules that don't have a stamp attribute#3829krasimirgg merged 9 commits intobazelbuild:mainfrom
krasimirgg merged 9 commits intobazelbuild:mainfrom
Conversation
krasimirgg
approved these changes
Jan 29, 2026
jason-rl
pushed a commit
to runloopai/rules_rust
that referenced
this pull request
Feb 4, 2026
…3829) Rules that don't have a `stamp` attribute, for example `rust_cc_proto_library_aspect`, should not be treated as stamped. This was broken by bazelbuild#3816 - prior to that, we were returning false because they also don't have a `_stamp_flag ` attribute. By returning true for `rust_cc_proto_library_aspect`, we're unnecessarily including the volatile stamp files as action inputs, which harms build caching. --------- Co-authored-by: Krasimir Georgiev <krasimir@google.com>
dzbarsky
added a commit
to dzbarsky/rules_rust
that referenced
this pull request
Feb 7, 2026
…elbuild#3829)" This reverts commit f198dde.
dzbarsky
added a commit
to dzbarsky/rules_rust
that referenced
this pull request
Feb 16, 2026
…elbuild#3829)" This reverts commit f198dde.
dzbarsky
added a commit
to dzbarsky/rules_rust
that referenced
this pull request
Feb 18, 2026
…elbuild#3829)" This reverts commit f198dde.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rules that don't have a
stampattribute, for examplerust_cc_proto_library_aspect, should not be treated as stamped. This was broken by #3816 - prior to that, we were returning false because they also don't have a_stamp_flagattribute.By returning true for
rust_cc_proto_library_aspect, we're unnecessarily including the volatile stamp files as action inputs, which harms build caching.