[draft] staticlib -- add an option to remove .rmeta from .rlibs#4145
Draft
krasimirgg wants to merge 2 commits into
Draft
[draft] staticlib -- add an option to remove .rmeta from .rlibs#4145krasimirgg wants to merge 2 commits into
krasimirgg wants to merge 2 commits into
Conversation
This guards the behavior of removing metadata from static libraries to avoid linker errors when using alwayslink on rust_library targets linked into cc_binary. Fixes bazelbuild#3722
Adapt std_libs_support_srcs_outside_package_test to force the setting to False, and add std_libs_support_srcs_outside_package_remove_metadata_test to test the behavior when the setting is True.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.