Support setting minimum OS version in -target
#1631
Draft
+287
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/add-min-os-version-attr
branch
6 times, most recently
from
2b9bda4 to
eab440f
Compare
See the linked issue in rules_swift_package_manager for rational for this change. We need to allow targets to set their target triple with the min os version. Changes in apple_support to export the Xcode SDK information allows us to pipe this down to the rules. Related: cgrindel/rules_swift_package_manager#892
luispadron
force-pushed
the
luis/add-min-os-version-attr
branch
from
eab440f to
b106010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the linked issue in rules_swift_package_manager for why this change is needed. We need to allow targets to set their target triple with the min os version. Changes in apple_support to export the Xcode SDK information allows us to pipe this down to the rules.
Related: cgrindel/rules_swift_package_manager#892