Union types #315
Draft
Union types #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a top type. Previously it was omitted in the design, but it is needed to correctly type methods in the builtin method library.
brandjon
approved these changes
May 20, 2025
| ### Unions | ||
|
|
||
| Some functions may accept parameters of multiple types. In this | ||
| case parameter is annotated with a union type `A|B`. |
| Some functions may accept parameters of multiple types. In this | ||
| case parameter is annotated with a union type `A|B`. | ||
|
|
||
| User functions are limited to optional types, that is `None|A`, |
There was a problem hiding this comment.
Nit: "user functions" might be ambiguous between application-defined vs starlark-programmer-defined. Maybe "Starlark-defined functions"? Not sure whether there's precedent terminology elsewhere in this spec.
| @@ -3333,6 +3350,8 @@ See https://github.com/bazelbuild/starlark/issues/47. | |||
|
|
|||
| ### float | |||
|
|
|||
| `float(x: str|bool|int|float, /) -> float` | |||
There was a problem hiding this comment.
(No action needed for this PR) There may be a bunch of other args to other builtins that are Noneable, in the sense that we take None as an alternative to omitting the parameter entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.