Convert macros to rules and consolidate into one for Crashlytics #20
+184
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves two things:
1. Previously we could not use `select` in e.g. `package_name`
This is useful for having one target across multiple environments.
e.g. `package_name = select({"dev": "com.my.app.debug"})`
But because these were macros, select was not being evaluated.
2. Ergonomics of invoking multiple macros
Now there is a single thing to do in the build file. This also
reduces duplication: previously you had to specify package name
twice.
pswaminathan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves two things:
selectin e.g.package_nameThis is useful for having one target across multiple environments. e.g.
package_name = select({"dev": "com.my.app.debug"})But because these were macros, select was not being evaluated.Now there is a single thing to do in the build file. This also reduces duplication: previously you had to specify package name twice.
This would be a breaking change to consumers, so I'm wary of that. But I'm not sure how many others would feel this to be a regression, so I would love to hear feedback.