Skip to content

Fix find_button to find the exact match for the button #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danni
Copy link
Contributor

@danni danni commented Sep 17, 2014

Including only normalising the space.

This also means we only make one XPath request.

Including only normalising the space.

This also means we only make one XPath request.
@danni
Copy link
Contributor Author

danni commented Sep 17, 2014

Was generally thinking of going through and cleaning up the XPath for all of the steps to reduce the number of round trips to Selenium required to use LWD.

@npilon
Copy link
Collaborator

npilon commented Sep 30, 2014

I'm not convinced that generating complicated xpath like this is actually a win. It definitely improves performance, but I can barely read it.

@danni
Copy link
Contributor Author

danni commented Sep 30, 2014

What would make it more readable?

@npilon
Copy link
Collaborator

npilon commented Oct 1, 2014

Perhaps starting with '//button[normalize-space(text())="{value}"]'.format(value=value) and then using += '|stuff' to expand it? I think in this case I'd find that more readable than a generator expression and join.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants