Skip to content

Conversation

@ryanmccartney
Copy link
Contributor

📺 What

Allows DASH manifests which specifies a metric reporting block in the following form;

<Metrics metrics="HttpList(50,MediaSegment),RepSwitchList,PlayList,TcpList,DVBErrors"> 
    <Reporting schemeIdUri="urn:dvb:dash:reporting:2014" value="1" dvb:reportingUrl="h  ttps://example.com/metrics" dvb:probability="1000"/> 
</Metrics>

to report to the endpoint.

🛠 How

Changes the Dash.js import to use dashjs instead of index_mediaplayerOnly, additionally adds setXHRWithCredentialsForType("DVBReporting", true) to allow cookies to be passed with any of these reporting requests by the place - this is required in order to ID the session.

✅ Testing [Semi-optional]

Mock player expanded to include setXHRWithCredentialsForType method.

Test Guidelines

Test engineer sign off

Bundle size could change as a result of this PR.

@ryanmccartney ryanmccartney requested a review from a team as a code owner December 9, 2024 16:02
@ryanmccartney ryanmccartney marked this pull request as draft December 9, 2024 16:03
@ryanmccartney ryanmccartney marked this pull request as ready for review February 10, 2025 10:28
@ryanmccartney ryanmccartney force-pushed the dvb-metrics-reporting branch from 14c9e1e to ef7c367 Compare March 5, 2025 14:56
@ryanmccartney
Copy link
Contributor Author

PR now brought up to date with 9.0.2

@ryanmccartney
Copy link
Contributor Author

Closing without merging as this functionality is now available as part of changes to support DRM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant