Introduce Abort Initialisation After TearDown #400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Introduces the concept of aborting initialisation if Bigscreen Player has already been torn down.
This prevents the issue where, if BSP is torn down during initialisation,
TypeError: Cannot read properties of null (reading 'manifestType')orCannot read properties of undefined (reading 'time')is thrown, depending on wheremediaSources.time().manifestTypeis called. These errors can be caused bytearDown()tearing down and de-referencingmediaSourceswhilst BSP is in the process of initialising.🛠 How
AbortSignalwhich keeps the state of if BSP has been torn down. Also provides athrowIfAbortederror which throws anAbortError.AbortErrorhas a custom name and message.signal.abort()on invocation oftearDown().abortutils.bigscreenplayerandplayercomponent.✅ Testing