Video frames not advancing updates #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmccartney
added
semver patch
ShiningTrapez
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Updates Dash.js with new version (smp-v4.7.3-11) and adds total frames debugging.
🛠 How
Brings in additional checks to
videoFramesNotAdvancingfunction in Dash.js. Checks that we're not at the start or end of playback. Ignores these periods. Additionally, ignores periods where the player is seeking.Passes further information with the
PLAYBACK_FROZENevent to aid debugging.Adds
frames-totalas a static metric to aid debugging of this issue or similar ones in the future.