Skip to content

Conversation

@JoeBBC
Copy link
Contributor

@JoeBBC JoeBBC commented Oct 21, 2025

📺 What

Fixes a bug where IMSC subtitles remained on-screen after seeking to a time without a subtitle

🛠 How

After a seek is detected:

  • Removes the subtitle DOM element
  • Clears state to ensure a check is always performed to render a subtitle if available

A seek is detected if, over a 750ms period, playback time reverses, or jumps forward by > 2 seconds

✅ Testing
Test Guidelines

Test engineer sign off

Added 3 unit tests which operate with mock data:

  • Ensure subtitles are removed after seeking back to a time without a subtitle
  • Ensure subtitles remain rendered after seeking forward to a time with a subtitle (within the same long-duration subtitle)
  • Ensure subtitles remain rendered after seeking back & forth (within the same long-duration subtitle) between different segments of a live-stream

@JoeBBC JoeBBC requested a review from a team as a code owner October 21, 2025 12:54
@JoeBBC JoeBBC added bug fix Fix a bug semver patch This PR is a semver patch release labels Oct 21, 2025
@ShiningTrapez ShiningTrapez merged commit 76e241e into master Oct 29, 2025
4 checks passed
@ShiningTrapez ShiningTrapez deleted the BADGER-16-HideSubtitlesWhenSeekingAway branch October 29, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix Fix a bug semver patch This PR is a semver patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants