BADGER-254: Report quality changes more consistently #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiningTrapez
previously approved these changes
Nov 26, 2025
Contributor
ShiningTrapez
left a comment
ShiningTrapez
left a comment
There was a problem hiding this comment.
Huh I thought I fixed that typo ages ago
ShiningTrapez
previously approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📺 What
Title. Dash.js doesn't always fire a qualitychangerequested event on startup. (I suspect this happens when the streaminitialised event fires before qualitychangerequested). This breaks the ACT test.
🛠 How
Add
downloadqualitychangeandplaybackqualitychangeplugin events to replacequalitychangerendered/requestedexposed directly from Dash.js. Fires onstreaminitialisedandRepSwitchList(a metric added on every repswitch)