Update Read Mes #12450
Merged
Update Read Mes #12450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
requested changes
Mar 3, 2025
emilysaffron
reviewed
Mar 3, 2025
karinathomasbbc
approved these changes
Mar 26, 2025
|
|
||
| Below is a bare-bones example of how BUMP is used. To get a video working we provide BUMP with a valid settings object as outlined below. | ||
|
|
||
| - Cookbook provides us with a list of settings available: [Cook book link](https://cookbook.tools.bbc.co.uk/iplayer/customise) |
There was a problem hiding this comment.
Are we OK sharing these internal BBC links in open source readmes?
HarveyPeachey
approved these changes
Mar 26, 2025
| ├── Placeholder | ||
| ├── index.tsx | ||
|
|
||
| The MediaLoader component takes in a video block from the BFF and converts it into a BUMP settings object. The BFF does not provide video blocks in a uniformed way since our editors publish videos from different sources. For greater flexibility, we allow the BFF to provide video data in its native form and use respective scripts within the configs folder to process the data into a BUMP settings object. The logic for this is as follows: |
There was a problem hiding this comment.
To help me understand better, what do you mean by: "The BFF does not provide video blocks in a uniformed way since our editors publish videos from different sources".?
There was a problem hiding this comment.
Explained in person.
Isabella-Mitchell
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: No Jira
Overall changes
Updates the following Read Mes: