Skip to content

Comments

WORLDSERVICE-280: Adds grid storybook example with media#12526

Merged
Isabella-Mitchell merged 10 commits intolatestfrom
WORLDSERVICE-280-storybook-example
May 1, 2025
Merged

WORLDSERVICE-280: Adds grid storybook example with media#12526
Isabella-Mitchell merged 10 commits intolatestfrom
WORLDSERVICE-280-storybook-example

Conversation

@Isabella-Mitchell
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell commented Mar 19, 2025

PR to support WORLDSERVICE-280 - Promo Media Icon not showing in hierarchical curation in large breakpoints

Overall changes

Adds grid curation example with media icon. Ready for developers who pick up WORLDSERVICE-280.

Story in desktop breakpoint (no media icon or duration)
Screenshot 2025-05-01 at 08 55 08

Story in breakpoint (media icon/ duration is visible)
Screenshot 2025-05-01 at 08 54 57

Code changes

  • Adds fixture data
  • Adds story variation
  • Adds chromatic snapshot

Testing

  1. Go to Storybook permalink, go to Curation Grid Hierarchical component
  2. Use 'controls' in right hand menu to select 'withMedia'

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@Isabella-Mitchell Isabella-Mitchell marked this pull request as ready for review April 1, 2025 13:27
@Louis-Matsika
Copy link
Contributor

Screenshot 2025-04-01 at 4 25 50 PM

is this what I'm supposed to see?

@karinathomasbbc
Copy link
Contributor

Are we expecting a snapshot too? If not, should we? It might be good if we can see the visual diff once we have resolved WORLDSERVICE-280.

@Isabella-Mitchell
Copy link
Contributor Author

Are we expecting a snapshot too? If not, should we? It might be good if we can see the visual diff once we have resolved WORLDSERVICE-280.

Done

@Isabella-Mitchell Isabella-Mitchell merged commit 880ef9b into latest May 1, 2025
11 checks passed
@Isabella-Mitchell Isabella-Mitchell deleted the WORLDSERVICE-280-storybook-example branch May 1, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants