-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WORLDSERVICE-284 Automated testing to determine the weight of lite pages #12561
WORLDSERVICE-284 Automated testing to determine the weight of lite pages #12561
Conversation
Co-authored-by: Karina Thomas <[email protected]>
Co-authored-by: Karina Thomas <[email protected]>
Co-authored-by: Karina Thomas <[email protected]>
Co-authored-by: Karina Thomas <[email protected]>
Co-authored-by: Karina Thomas <[email protected]>
Co-authored-by: Karina Thomas <[email protected]>
I've noticed quite a big discrepancy between On Demand TV Brand pages - looks like https://www.bbc.com/gujarati/bbc_gujarati_tv/tv_programmes/w13xttqr.lite?renderer_env=live 404s. I think we should add some error checking, and ensure the response we get back from the curl is a 200. |
One to note is We may want to do something to highlight 404s and either not try and calculate the size and/or display a warning that the route 404'd? |
…f github.com:bbc/simorgh into SPIKE-WORLDSERVICE-284-automate-litepage-weight-test
|
||
console.table(testResults.sort((a, b) => b.localSizeKb - a.localSizeKb)); | ||
|
||
const failures = testResults.filter(({ result }) => result === '❌'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy since this works and it is a developer script. Though I'm not sure I've seen a strict equality check against an emoji before! ===😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a test to fix
…f github.com:bbc/simorgh into SPIKE-WORLDSERVICE-284-automate-litepage-weight-test
Resolves JIRA: WORLDSERVICE-284
Summary
Adds a script to check page weight of lite pages on live and local, running as part of the local server github action.
Code changes
Developer Checklist
Testing
Ready-For-Test, Local
)Ready-For-Test, Test
)Ready-For-Test, Preview
)Ready-For-Test, Live
)Additional Testing Steps
Useful Links