Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Bar OJ - Pass Optimizely to applyBasicPageHandlers #12564

Merged
merged 9 commits into from
Mar 26, 2025

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented Mar 24, 2025

Summary

Passes Optimizely to the applyBasicPageHandlers HOC via the handlerBeforeContexts prop. This allows the OptimizelyContext to be exposed to components outside of just the ArticlePage component, such as the Header component where the Top Bar OJ experiment is used.

Adds checks to Scrollable to ensure Optimizely events are only sent when the component is in the experiment section of the page.

Adds missing click event handler for experimental version of PromoList.

Code changes

  • Adds Optimizely HOC to applyBasicPageHandlers HOC
  • Adds check for experimentVariant in ScrollablePromo to ensure it doesn't send Optimizely events for the normal usage of ScrollablePromo

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

@amoore108 amoore108 self-assigned this Mar 24, 2025
@amoore108 amoore108 changed the title Top Bar OJ - Add Optimizely to root layout Top Bar OJ - Add Optimizely to applyBasicPageHandlers Mar 24, 2025
Copy link
Contributor

@eagerterrier eagerterrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm-ship-it

Copy link
Contributor

@HarveyPeachey HarveyPeachey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/

@amoore108 amoore108 changed the title Top Bar OJ - Add Optimizely to applyBasicPageHandlers Top Bar OJ - Pass Optimizely to applyBasicPageHandlers Mar 25, 2025
@amoore108 amoore108 requested a review from HarveyPeachey March 26, 2025 08:49
@amoore108 amoore108 merged commit 15a59f5 into latest Mar 26, 2025
11 checks passed
@amoore108 amoore108 deleted the top-bar-add-optimizely-to-root-layout branch March 26, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants