Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addchartbeat to lite with size check #12565

Closed
wants to merge 1,198 commits into from
Closed

Addchartbeat to lite with size check #12565

wants to merge 1,198 commits into from

Conversation

emilysaffron
Copy link
Contributor

Resolves JIRA:

Summary

A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.

Code changes

  • A bullet point list of key code changes that have been made.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

Louis-Matsika and others added 30 commits March 12, 2025 16:28
@Louis-Matsika
refactor
e192dab
@Louis-Matsika
revert unintended changes
8278e7b
@pvaliani
try this again...add dependency resolution for babel at 7.26.10
fbc7906
@pvaliani
Revert "try this again...add dependency resolution for babel at 7.26.10"
23d8031 
This reverts commit fbc7906.
@Louis-Matsika
revert unintended changes 2
64b9b0e
@andrewscfc
upgrade to babel/runtime without resolutions
563f5e0
@holchris
Merge branch 'WORLDSERVICE-366-reverb-rollout-enable-reverb-on-live-b…
ba70442 
…atch-2' into WORLDSERVICE-367-reverb-roll-out-enable-reverb-on-live-batch-3
@LilyL0u
Merge pull request #12468 from bbc/WORLDSERVICE-366-reverb-rollout-en…
cb05580 
…able-reverb-on-live-batch-2

Worldservice 366 reverb rollout enable reverb on live batch 2
@karinathomasbbc
Merge branch 'latest' into WORLDSERVICE-420-ps-manifest-file
cceaec9
@karinathomasbbc
Merge branch 'WORLDSERVICE-420-ps-manifest-file' into WORLDSERVICE-42…
29572d7 
…0-amp-manifest-file-checker
@louisearchibald
Merge branch 'latest' into WORLDSERVICE-368-reverb-rollout-enable-rev…
1bc409d 
…erb-on-live-batch-4-services
@karinathomasbbc
Bump next to from 15.1.16 to 15.2.2 (#12507)
00327ef
@louisearchibald
Merge branch 'latest' into WORLDSERVICE-368-reverb-rollout-enable-rev…
3a80b1f 
…erb-on-live-batch-4-services
@LilyL0u
Merge branch 'latest' into WORLDSERVICE-367-reverb-roll-out-enable-re…
35ec2b2 
…verb-on-live-batch-3
@karinathomasbbc @pvaliani
WORLDSERVICE-185: Replace uuid with crypto.randomUUID (#12361)
51131b8 
* Replace references of uuid with crypto.randomUUID

* Delete incorrect import

* Update test

* Update bundle size :grimace:

* Fix tests

* Use original mock value

* Fix test

* Mocking of uuid

* Linting

* Fix test

* Mock UUID

* Fix tests

* Correct uuid format

* Correct uuid format

* Correct uuid format

* Remove console log

* Fix test

* Enforce SSL encryption of cookie

* Remove outdated package

* Increase bundle size

* Mock optimizely in tests

* Fix tests

* Remove unnecessary line

---------

Co-authored-by: Pedram <[email protected]>
@pvaliani
add zhongwen reverb config
5d477b7
@amoore108
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
007ffef 
…ssociated-code
@amoore108
Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…
899a7b0 
…ssociated-code
@amoore108
Update bundleSizeConfig.js
6df2b52
@louisearchibald
Merge branch 'latest' into WORLDSERVICE-368-reverb-rollout-enable-rev…
09b0460 
…erb-on-live-batch-4-services
@pvaliani
add japanese, update zhongwen
bf40774
@pvaliani
add hausa
aecf1fd
@pvaliani
add reverb usage to hausa e2es for atianalytics
a050f95
@pvaliani
Merge branch 'latest' into WORLDSERVICE-369-reverb-rollout-batch-5
36a9f58
@louisearchibald
Merge branch 'WORLDSERVICE-368-reverb-rollout-enable-reverb-on-live-b…
d12ec2b 
…atch-4-services' of github.com:bbc/simorgh into WORLDSERVICE-368-reverb-rollout-enable-reverb-on-live-batch-4-services
@pvaliani
update tests
1527ed5
@amoore108
Live page SEO optional chaining (#12513)
cc4ce85 
* Live page SEO optional chaining

* One more to help me sleep at night
@pvaliani
Merge branch 'latest' into WORLDSERVICE-369-reverb-rollout-batch-5
e79d1de
@amoore108
Update bundleSizeConfig.js
a585265
@karinathomasbbc
Remove references to previous path as it is no longer required (#12402)
87f8c72 
* Remove previousPath

* Remove previousPath

* getReferrer only requires platform as a param

* Reinstate getAtUserId as it was accidentially deleted

* Fix tests

* Fix tests

* Reinstate accidentally deleted variable

* Reinstate accidentally deleted variable

* Only set virtual referrer on AMP now that previous path has been removed

* Resinstate check for document.referrer
@emilysaffron emilysaffron marked this pull request as draft March 25, 2025 16:19
amoore108 and others added 16 commits March 26, 2025 09:34
@amoore108 @louisearchibald
Top Bar OJ - Pass Optimizely to applyBasicPageHandlers (#12564)
15a59f5 
* Top Bar OJ - Add Optimizely to root layout

* Update index.jsx

* Revert export change - mock SDK

* Add mock to applyBasicPageHandlers

* Add to `applyBasicPageHandlers` instead

* use handlerBeforeContexts parameter

* Remove `withOptimizelyProvider` from `applyBasicPageHandlers`

---------

Co-authored-by: louisearchibald <[email protected]>
Co-authored-by: louisearchibald <[email protected]>
@emilysaffron
handle non-200 status codes
47f5850
@emilysaffron
Merge branch 'SPIKE-WORLDSERVICE-284-automate-litepage-weight-test' o…
7072732 
…f github.com:bbc/simorgh into SPIKE-WORLDSERVICE-284-automate-litepage-weight-test
@emilysaffron
Merge branch 'latest' into SPIKE-WORLDSERVICE-284-automate-litepage-w…
25d61a3 
…eight-test
@emilysaffron
fix typo
a55e14d
@dependabot @amoore108
Bump @types/react from 19.0.10 to 19.0.12 in the react group (#12551)
cd3671f 
Bumps the react group with 1 update: [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react).


Updates `@types/react` from 19.0.10 to 19.0.12
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: react
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Moore <[email protected]>
@dependabot @amoore108
Bump the storybook group with 14 updates (#12552)
9f44fe0 
Bumps the storybook group with 14 updates:

| Package | From | To |
| --- | --- | --- |
| [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y) | `8.6.6` | `8.6.8` |
| [@storybook/addon-backgrounds](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/backgrounds) | `8.6.6` | `8.6.8` |
| [@storybook/addon-controls](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/controls) | `8.6.6` | `8.6.8` |
| [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/docs) | `8.6.6` | `8.6.8` |
| [@storybook/addon-toolbars](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/toolbars) | `8.6.6` | `8.6.8` |
| [@storybook/addon-viewport](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/viewport) | `8.6.6` | `8.6.8` |
| [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/blocks) | `8.6.6` | `8.6.8` |
| [@storybook/builder-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/builders/builder-webpack5) | `8.6.6` | `8.6.8` |
| [@storybook/cli](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli) | `8.6.6` | `8.6.8` |
| [@storybook/core-common](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/core-common) | `8.6.6` | `8.6.8` |
| [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react) | `8.6.6` | `8.6.8` |
| [@storybook/react-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/react-webpack5) | `8.6.6` | `8.6.8` |
| [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming) | `8.6.6` | `8.6.8` |
| [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli) | `8.6.6` | `8.6.8` |


Updates `@storybook/addon-a11y` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/addons/a11y)

Updates `@storybook/addon-backgrounds` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/addons/backgrounds)

Updates `@storybook/addon-controls` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/addons/controls)

Updates `@storybook/addon-docs` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/addons/docs)

Updates `@storybook/addon-toolbars` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/addons/toolbars)

Updates `@storybook/addon-viewport` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/addons/viewport)

Updates `@storybook/blocks` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/lib/blocks)

Updates `@storybook/builder-webpack5` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/builders/builder-webpack5)

Updates `@storybook/cli` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/v8.6.8/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/lib/cli)

Updates `@storybook/core-common` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/lib/core-common)

Updates `@storybook/react` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/renderers/react)

Updates `@storybook/react-webpack5` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/frameworks/react-webpack5)

Updates `@storybook/theming` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/lib/theming)

Updates `storybook` from 8.6.6 to 8.6.8
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/v8.6.8/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.6.8/code/lib/cli)

---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/addon-backgrounds"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/addon-controls"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/addon-docs"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/addon-toolbars"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/addon-viewport"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/blocks"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/builder-webpack5"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/core-common"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/react-webpack5"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/theming"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: storybook
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Moore <[email protected]>
@dependabot @amoore108
Bump helmet from 8.0.0 to 8.1.0 (#12553)
94fdb52 
Bumps [helmet](https://github.com/helmetjs/helmet) from 8.0.0 to 8.1.0.
- [Changelog](https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md)
- [Commits](helmetjs/helmet@v8.0.0...v8.1.0)

---
updated-dependencies:
- dependency-name: helmet
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aaron Moore <[email protected]>
@dependabot
Bump supertest from 7.0.0 to 7.1.0 (#12554)
e129e9a 
Bumps [supertest](https://github.com/ladjs/supertest) from 7.0.0 to 7.1.0.
- [Release notes](https://github.com/ladjs/supertest/releases)
- [Commits](ladjs/supertest@v7.0.0...v7.1.0)

---
updated-dependencies:
- dependency-name: supertest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@emilysaffron
Merge branch 'latest' into SPIKE-WORLDSERVICE-284-automate-litepage-w…
5ecd860 
…eight-test
@shayneahchoon @eagerterrier
Update Read Mes (#12450)
2de617c 
* WORLDSERVICE-UPDATE: Update readme

* WORLDSERVICE-UPDATE: Update readme

* WORLDSERVICE-README: Edit MediaLoader

* WORLDSERVICE-README: Edit MediaLoader

* WORLDSERVICE-README: Edit MediaLoader

* WORLDSERVICE-README: Edit MediaLoader

* WORLDSERVICE-README: Edit MediaLoader

* WORLDSERVICE-README: Edit MediaLoader

* WORLDSERVICE-README: Edit readme

* WORLDSERVICE-README: Update media content

---------

Co-authored-by: Toby Cox <[email protected]>
@HarveyPeachey
Merge branch 'latest' into SPIKE-WORLDSERVICE-284-automate-litepage-w…
719e329 
…eight-test
@karinathomasbbc
Rename application cypress file so that the E2E tests will run
e80cce7
@emilysaffron
remove 404ing paths
26f6865
@emilysaffron
Merge branch 'SPIKE-WORLDSERVICE-284-automate-litepage-weight-test' o…
732d81a 
…f github.com:bbc/simorgh into SPIKE-WORLDSERVICE-284-automate-litepage-weight-test
@emilysaffron
Merge pull request #12561 from bbc/SPIKE-WORLDSERVICE-284-automate-li…
99057d5 
…tepage-weight-test

WORLDSERVICE-284 Automated testing to determine the weight of lite pages
Base automatically changed from SPIKE-WORLDSERVICE-284-automate-litepage-weight-test to latest March 27, 2025 11:25
@karinathomasbbc karinathomasbbc changed the base branch from latest to lite-chartbeat-initial-impl March 28, 2025 10:54
@karinathomasbbc
Copy link
Contributor

Superceded by #11579 now that the Lite Site tests have been merged to latest

@karinathomasbbc karinathomasbbc deleted the addchartbeat-to-lite-with-size-check branch March 28, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.