-
Notifications
You must be signed in to change notification settings - Fork 258
WS-1687 - Personalised Topic Rail for Adaptive Experience (Data Fetching via NextJS) #13071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LilyL0u
wants to merge
40
commits into
latest
Choose a base branch
from
wip-personalised-rail
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+345
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen adding personalisedContent
…ch logic to allow topic to silently fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://bbc.atlassian.net/browse/WS-1687 and https://bbc.atlassian.net/browse/WS-1688
Related to https://bbc.atlassian.net/browse/WS-1685
Summary
Adds a
PersonalisedContentcomponent containing 4 Topics served based on the users header value forx-country. Tracking is enabled as a section view and per-link clicks with click tracking also added to the Topic as subheading link.Fetch the country-specific topic feed in the Next.js article handler and inject secondaryColumn.PersonalisedContent when
x-country/x-bbc-edge-countrymatches the Mundo mapping. Slices to 4 summaries.Articles are configured to still render if a topic ID is invalid/missing and fails.
Guard secondary data handling (secondaryData || {}) to avoid errors when secondaryColumn is absent.
Light tests added/adjusted as appropriate
Chile Topic:

Mexico Topic:

Argentina Topic (

x-countryheader setting shown):Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links