WS-1396: Lite site caching PoC #13255
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…rolled format string Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
andrewscfc
reviewed
Oct 21, 2025
Contributor
andrewscfc
left a comment
andrewscfc
left a comment
There was a problem hiding this comment.
few questions to aid my understanding 👍
| return response; | ||
| })(), | ||
| ); | ||
| } else if (isRequestForMostRead) { |
Contributor
There was a problem hiding this comment.
where is this variable defined? I can't find it anywhere on the diff?
| )}`; | ||
| const HOME_PAGE_URL = `${getEnvConfig().SIMORGH_BASE_URL}/${service}`; | ||
|
|
||
| const fetchMostReadItems = async () => { |
Contributor
There was a problem hiding this comment.
why can't this request be made from within the service worker?
| const cache = await caches.open(cacheName); | ||
| if (hasOfflinePageFunctionality) { | ||
| await cache.add(OFFLINE_PAGE); | ||
| await cacheMostReadStories(cache); |
Contributor
There was a problem hiding this comment.
where is this function defined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft PoC for JIRA: WS-1396 SPIKE: Lite site homepage caching in offline mode
Summary
A PR to showcase lite site homepage and most read articles caching capabilities.
Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links