Skip to content

Conversation

@alex-magana
Copy link
Contributor

Resolves JIRA: WS-222

Summary

Remove old ATI/Piano tracking logic for AMP pages.

Code changes

  • Remove pageviewParams from the AmpATIAnalytics component.
  • Exclusively use getAmpAnalyticsPageViewUrl from reverb-url-helper for AMP page view tracking.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. Visit the sample assets below.
  2. From the Network tab of the Developer Console, check that the page view beacon is triggered.
http://localhost:7081/gahuza/articles/cz91q9n4y11o.amp?renderer_env=live
http://localhost:7081/news/articles/cly4wxnxxj2o.amp?renderer_env=live

Useful Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants