Skip to content

Conversation

@louisearchibald
Copy link
Contributor

@louisearchibald louisearchibald commented Nov 13, 2025

Resolves JIRA: WS-1258

Summary

Updates the Live TV Page to add metadata for SEO and analytics tracking for user behaviour.

Code changes

  • Reinstates Chartbeat and AtiAnalytics components to the page, populated with relevant values.
  • Adds LIVE_TV_PAGE pageType to Chartbeat and updates relevant tests.
  • Adds LinkedData component.
  • Updates existing type to include seoTitle & seoDescription props.
  • Adds unit tests.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

@louisearchibald louisearchibald self-assigned this Nov 13, 2025
louisearchibald and others added 24 commits November 14, 2025 09:18
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
@louisearchibald louisearchibald marked this pull request as ready for review November 20, 2025 15:17
@pvaliani pvaliani self-requested a review November 20, 2025 15:33
<LinkedData
type="TelevisionChannel"
seoTitle={metadataTitle}
description={seoDescription}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LinkedData is given only seoDescription so when the BFF supplies only description (as in the current fixture), the structured data will omit any description. I think that will break a “Linked Data for SEO” requirement and diverge from the meta tags, which already fall back to description/title

@pvaliani
Copy link
Contributor

Live TV now fires Chartbeat, but Chartbeat doesn’t have the live tv page type (src/app/components/ChartbeatAnalytics/utils/index.ts) around L48-L75, so it won’t add the brand suffix and will treat the page as an unknown “iveTV type.

Could consider adding LIVE_TV_PAGE to the TV/live cases so it lands correctly!

{/* <ATIAnalytics atiData={atiAnalytics} /> */}
{/* <ChartbeatAnalytics title={pageTitle} /> */}
<ATIAnalytics atiData={atiAnalytics} />
<ChartbeatAnalytics title={title} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: my comment on the main PR this is where Chartbeat is firing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, have added the pageType to Chartbeat now, thanks 😄

Copy link
Contributor

@amoore108 amoore108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Copy link
Contributor

@pvaliani pvaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️

@louisearchibald louisearchibald merged commit 9c37d9a into latest Nov 25, 2025
13 checks passed
@louisearchibald louisearchibald deleted the WS-1743-add-analytics-to-live-tv-page branch November 25, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants