-
Notifications
You must be signed in to change notification settings - Fork 258
WS-1743 - Add analytics & metadata to Live TV page #13426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WS-1743 - Add analytics & metadata to Live TV page #13426
Conversation
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
…com/bbc/simorgh into WS-1743-add-analytics-to-live-tv-page
| <LinkedData | ||
| type="TelevisionChannel" | ||
| seoTitle={metadataTitle} | ||
| description={seoDescription} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LinkedData is given only seoDescription so when the BFF supplies only description (as in the current fixture), the structured data will omit any description. I think that will break a “Linked Data for SEO” requirement and diverge from the meta tags, which already fall back to description/title
|
Live TV now fires Chartbeat, but Chartbeat doesn’t have the live tv page type (src/app/components/ChartbeatAnalytics/utils/index.ts) around L48-L75, so it won’t add the brand suffix and will treat the page as an unknown “iveTV type. Could consider adding |
| {/* <ATIAnalytics atiData={atiAnalytics} /> */} | ||
| {/* <ChartbeatAnalytics title={pageTitle} /> */} | ||
| <ATIAnalytics atiData={atiAnalytics} /> | ||
| <ChartbeatAnalytics title={title} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: my comment on the main PR this is where Chartbeat is firing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, have added the pageType to Chartbeat now, thanks 😄
amoore108
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
pvaliani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛳️
Resolves JIRA: WS-1258
Summary
Updates the Live TV Page to add metadata for SEO and analytics tracking for user behaviour.
Code changes
ChartbeatandAtiAnalyticscomponents to the page, populated with relevant values.LIVE_TV_PAGEpageType to Chartbeat and updates relevant tests.LinkedDatacomponent.seoTitle&seoDescriptionprops.Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links