-
Notifications
You must be signed in to change notification settings - Fork 258
WS-1674 Implement Temporary UX Solution for Portrait Video Promo Display on Index Pages #13432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
emilysaffron
wants to merge
40
commits into
latest
Choose a base branch
from
WS-1674-PVdisplayintopicpromo
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+488
−69
Draft
Changes from 29 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
c27fe8b
detect portrait image + add style
emilysaffron 1625b1b
add gradient
emilysaffron 95dffb3
update tests
emilysaffron f49add0
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron 4f4886e
undo commented out effect
emilysaffron 7b630d5
Merge branch 'WS-1674-PVdisplayintopicpromo' of github.com:bbc/simorg…
emilysaffron 154c975
update bundle size max
emilysaffron cae21d3
update integration snapshots
emilysaffron c35f5a2
update z index for play button
emilysaffron 72bcb8c
add isCurationPromo condition
emilysaffron 6269515
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron 6182c31
add storybook example
emilysaffron 581ea37
Merge branch 'WS-1674-PVdisplayintopicpromo' of github.com:bbc/simorg…
emilysaffron f5a3c88
update default state
emilysaffron 5ba9a81
clean up
emilysaffron 4e2d44a
clean up
emilysaffron 2de54b5
snapshots
emilysaffron 899ceb0
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron 741bda6
remove conditional
emilysaffron 0358f97
conditinal on all promos
emilysaffron 501c66b
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron 4b06899
fix accidental changes
emilysaffron d631a25
integration
emilysaffron 693cfd2
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron 0e0bd24
default to false for portrait
emilysaffron 23164e3
Merge branch 'WS-1674-PVdisplayintopicpromo' of github.com:bbc/simorg…
emilysaffron 58f222c
use white from theme
emilysaffron 8c83113
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron eafae85
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron a048344
use originalSize to set isPortrait
emilysaffron e48de6c
Merge branch 'WS-1674-PVdisplayintopicpromo' of github.com:bbc/simorg…
emilysaffron e68ff73
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron 74b8bd4
add default
emilysaffron 3a09577
Merge branch 'WS-1674-PVdisplayintopicpromo' of github.com:bbc/simorg…
emilysaffron 3c8f771
extend conditional
emilysaffron 17b1b0d
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron 3f0d5b2
conditionally call hook
emilysaffron 826c9cb
Merge branch 'WS-1674-PVdisplayintopicpromo' of github.com:bbc/simorg…
emilysaffron ca0a81d
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron fabf938
Merge branch 'latest' into WS-1674-PVdisplayintopicpromo
emilysaffron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilysaffron marked this conversation as resolved.
Show resolved
Hide resolved
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ const Image = ({ | |
| width={width} | ||
| height={height} | ||
| lazyLoad | ||
| isPromo | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.