WS-1385: move to biome from eslint and prettier 2#14044
Draft
eagerterrier wants to merge 51 commits into
Draft
Conversation
amoore108
reviewed
May 20, 2026
amoore108
reviewed
May 20, 2026
amoore108
reviewed
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing if biome is a good fit
Current Rules that don't exist in biome:
import/prefer-default-export(well,noDefaultExportexists, but generates 1,120 errors so it's either not set up the same way or we weren't doing it properly before. No point putting >1k suppressions in)import/namedCurrent Rules that don't seem to work in biome (or don't work well)
camelcase(it does support useNamingConvention but there were so many exceptions in our codebase I couldn't put the time in to sort out the rules and suppressions)no-restricted-syntax(usesnoLoopFuncandnoForIninstead, but doesn't seem to cover enough)@typescript-eslint/no-var-requires(probably taken care of withnoCommonJsandnoVarInstructions for VSCode
https://biomejs.dev/guides/editors/first-party-extensions/
You might want to play around with the settings, but a good start is
Expected impact
It's a long PR, but here's the break down of what's expected: