Fix: Shared Control without Timeline State #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
With no active timeline objects the Atem Integration will overwrite any changes made to Mix Effects by external actors. This is because the "old state" will have the external changes added to it but the "new state" will not get these changes (as there is no address to apply them to)
New Behavior
The Integration correctly responds to external actors even without active timeline objects (i.e. does nothing until the Address State is changed or Control Value changes)
It is up to individual integrations to choose how to deal with undefined states, i.e. if an external state for an address is overwriting a MixEffect that is not controlled through the timeline.