Skip to content

Avoid direct template expansion in run blocks#232

Open
mara004 wants to merge 2 commits into
bblanchon:masterfrom
mara004:templates
Open

Avoid direct template expansion in run blocks#232
mara004 wants to merge 2 commits into
bblanchon:masterfrom
mara004:templates

Conversation

@mara004

@mara004 mara004 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This addresses some findings from zizmor .github/ --persona auditor
See also https://docs.zizmor.sh/audits/#template-injection

[...] zizmor considers all template expansions in code contexts to be code smells, [even ones that are likely safe,] and attempting to selectively permit them is more error-prone than forbidding them in a blanket fashion.

Disclaimer: Untested

@mara004
mara004 marked this pull request as ready for review July 13, 2026 16:38
@mara004

mara004 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@bblanchon WDYT?

Also, do you have some advice if/how I should test this PR? (I wasn't sure it would be worth making a full batch of builds just for testing...)

@bblanchon

Copy link
Copy Markdown
Owner

I started a zizmor branch where i will try to fix all the warnings, but i had to put in on pause for the moment.

@mara004

mara004 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

I see, apologies for not having noticed the branch, and thank you for doing this work. Take your time. :)
Anyway, feel free to close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants