Allow setting RSpec expectations on a stub with options#1128
Open
inkstak wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows to verify a stubbed request has been requested with various options such as body, query or headers.
The differences with setting these options before making the request is that we can create a generic stubbed request and only then verify it has been made with our expectations.
The implementation is pretty simple since it uses the already existing
RequestExecutionVerifierto pass the options.We use this as a monkeypatch in our projects since years. I think it was time to make a PR.
I you think this is an interesting feature, I'll be happy to dive deeper and add tests to the PR.