[AS2-E2-S6] Add diagnostics helpers for probe and decode failures - #89
Merged
Conversation
Adds private diagnostics message constants with stable ASSET_* prefixes for runtime callback logs. Keeps the structure internal so public SDK headers do not expose diagnostic storage or error-code details.
Introduces an internal RuntimeContext helper that records diagnostics and dispatches filtered callback log events. This keeps failure-path logging consistent without changing public API shape.
Routes image and mesh probe/decode failures through the centralized runtime helper. Unsupported formats use warning logs, while malformed inputs and decoder rejection use error logs with the same existing Result mappings.
Routes LoadFile and decode-from-file load failures through the centralized diagnostic emission helper. File-not-found and IO failures now produce one error callback message while preserving existing Result mappings.
Marks the decode-from-file boundary where load diagnostics stop and blob decode diagnostics begin. This makes the single-log-per-failure-path rule explicit for future maintenance.
Records that this story covers probe, decode, file-load, and wrapper cleanup diagnostics. Keeps explicit invalid Release and Destroy validation paths non-logging unless a later story expands the scope.
Adds focused tests for unsupported decode logs, file-load logs, log-level filtering, and single decode-from-file emission. Callback capture now copies message text so assertions do not depend on pointer lifetime.
Verified Debug and Release builds with MSBuild. Ran Debug and Release unit tests, plus public header compile validation for both configurations.
Owner
Author
|
Review note:
Can we add a direct |
Adds direct LoadFile failure assertions to the runtime diagnostics file-load test. Verifies the blob-load callback message and handle state alongside the existing decode-from-file wrapper coverage.
Owner
Author
|
Hello again, I am a Humble Human C++ Developer. I addressed the review note by expanding What changed:
Validation:
Pushed commit: |
bboczula
marked this pull request as ready for review
June 10, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASSET_*callback prefixes.Resultmappings.Validation
Closes #45.