Compare manifest directory before passing manifest path#206
Merged
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202.
The current command builder compares
dir.parent()withdir, so a normal working directory always gets--manifest-pathappended. This changes the check to compare the current working directory with the selected manifest file's parent directory, which matches the intent from the surrounding code: only pass--manifest-pathwhen the selected package manifest is outside the working directory.I also split the target/message-format argument appending into a small helper so the same-package and different-package cases are covered directly.
Verification:
cargo fmt --all -- --checkcargo test cargo::tests --lockedcargo test --lockedcargo clippy -- -D warningsgit diff --checkreview-fix-loop: no actionable correctness issues found