Print NDK revision for verbose ndk-env#208
Closed
StantonMatt wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
Contributor
Author
|
Closing this in favor of #207, which solves the same issue more directly by exposing the detected revision as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #192; this is the verbose-output side, separate from #207's env-var export.
cargo ndkalready reports the detected NDK revision in verbose output, andcargo ndk-envuses the same NDK detection path but did not surface it. This adds accepted-v/--verboseand-q/--quietflags tondk-env, then prints the detected NDK revision/path on stderr in verbose mode so shell exports and JSON stdout stay clean by default.Validation:
cargo fmt --all -- --checkgit diff --check-vstderr detection output, and--quiet --verbosesuppressioncargo test --lockedcargo clippy -- -D warningsI did not find any actionable correctness issues)