Skip to content

Print NDK revision for verbose ndk-env#208

Closed
StantonMatt wants to merge 1 commit into
bbqsrc:mainfrom
StantonMatt:print-ndk-env-revision
Closed

Print NDK revision for verbose ndk-env#208
StantonMatt wants to merge 1 commit into
bbqsrc:mainfrom
StantonMatt:print-ndk-env-revision

Conversation

@StantonMatt

@StantonMatt StantonMatt commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Related to #192; this is the verbose-output side, separate from #207's env-var export.

cargo ndk already reports the detected NDK revision in verbose output, and cargo ndk-env uses the same NDK detection path but did not surface it. This adds accepted -v / --verbose and -q / --quiet flags to ndk-env, then prints the detected NDK revision/path on stderr in verbose mode so shell exports and JSON stdout stay clean by default.

Validation:

  • cargo fmt --all -- --check
  • git diff --check
  • fake-NDK smoke checks for default JSON output, -v stderr detection output, and --quiet --verbose suppression
  • cargo test --locked
  • cargo clippy -- -D warnings
  • review-fix-loop: clean (I did not find any actionable correctness issues)

Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
@StantonMatt

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #207, which solves the same issue more directly by exposing the detected revision as CARGO_NDK_NDK_VERSION in ndk-env output and already has the same green CI matrix. I opened this while working the same issue and do not want to leave two competing fixes open.

@StantonMatt StantonMatt closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant