Export NDK libclang path for bindgen#209
Merged
Merged
Conversation
Owner
|
@StantonMatt conflicts, please fix |
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
2f72540 to
e77bccf
Compare
Contributor
Author
|
Rebased onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201.
This exports
LIBCLANG_PATHwhen the selected NDK contains a hostlibclangshared library, sobindgen/clang-syscan find the NDK-provided libclang without extra user configuration.The lookup covers the host layouts I found in current and older NDK prebuilts:
libfor current Linux/macOS layoutslib64for older Linux/macOS layoutsbinfor Windowslibclang.dllmusl/libfor Linux musl prebuilts, preferred first on musl hostsVerification:
cargo fmt --all -- --checkcargo test cargo::tests --lockedcargo test --lockedcargo clippy -- -D warningsgit diff --check