Skip to content

Add opt-in internal vars to ndk-env#210

Merged
bbqsrc merged 1 commit into
bbqsrc:mainfrom
StantonMatt:include-internal-ndk-env
Jun 12, 2026
Merged

Add opt-in internal vars to ndk-env#210
bbqsrc merged 1 commit into
bbqsrc:mainfrom
StantonMatt:include-internal-ndk-env

Conversation

@StantonMatt

Copy link
Copy Markdown
Contributor

Summary

  • add cargo ndk-env --include-internal so cargo-ndk's internal linker wrapper variables stay hidden by default but can be exported when explicitly requested
  • quote sh and PowerShell output directly instead of relying on debug formatting, so _CARGO_NDK_LDFLAGS keeps its internal separator when sourced
  • document using the internal env in a subshell for direct cargo build

Fixes #185.

Testing

  • Docker rust:1.86.0-bookworm: cargo fmt --all -- --check
  • Docker rust:1.86.0-bookworm: cargo test --locked
  • Docker rust:1.86.0-bookworm: cargo clippy --locked -- -D warnings
  • Fake-NDK CLI smoke: default JSON hides internal vars; --include-internal JSON/sh/PowerShell includes them; sourced --include-internal --link-builtins output preserves _CARGO_NDK_LDFLAGS's separator

@bbqsrc bbqsrc merged commit a674fea into bbqsrc:main Jun 12, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include internal variables in cargo ndk-env

2 participants