Skip to content

DBC22-5246: removed the logic to set all feature as invisible to prevent icons from disappearing when page refreshed - #1184

Merged
wmuldergov merged 1 commit into
mainfrom
bugfix/DBC22-5246
Apr 23, 2026
Merged

DBC22-5246: removed the logic to set all feature as invisible to prevent icons from disappearing when page refreshed#1184
wmuldergov merged 1 commit into
mainfrom
bugfix/DBC22-5246

Conversation

@bcgov-brwang

Copy link
Copy Markdown
Collaborator

DBC22-5246: removed the logic to set all feature as invisible to prevent icons from disappearing when page refreshed

@bcgov-brwang
bcgov-brwang requested a review from ray-oxd January 20, 2026 21:50

@ray-oxd ray-oxd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain how you debugged this - in a meeting if needed. If I recall we're marking features as invisible and setting their styles again. How does this cause the bug to appear when we render from shared URLs?

…ent icons from disappearing when page refreshed
@bcgov-brwang

Copy link
Copy Markdown
Collaborator Author

Please explain how you debugged this - in a meeting if needed. If I recall we're marking features as invisible and setting their styles again. How does this cause the bug to appear when we render from shared URLs?

Debugging showed that during the initial load, styles are correctly applied to features along the searched route, but they are then wiped out by that block of code. As a result, the highlighted icons briefly appear and then disappear. In fact, that block isn’t necessary; there’s no need to manually clear all feature styles, since overlays are already removed when no route is searched.

@wmuldergov
wmuldergov merged commit 8d00173 into main Apr 23, 2026
9 of 11 checks passed
@wmuldergov
wmuldergov deleted the bugfix/DBC22-5246 branch April 23, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants