Skip to content

DBC22-6551/DBC22-5139: Move maint page to react and move env variables to index - #1352

Merged
bcgov-brwang merged 2 commits into
mainfrom
task/DBC22-6551
Jun 2, 2026
Merged

DBC22-6551/DBC22-5139: Move maint page to react and move env variables to index#1352
bcgov-brwang merged 2 commits into
mainfrom
task/DBC22-6551

Conversation

@wmuldergov

@wmuldergov wmuldergov commented May 28, 2026

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes/No) NO

🧪 How to Test (if required)

  1. Testing the Maintenance Page
  2. Go to the static deployment- >ENVIRONMENT
  3. Ensure you select Container = Config-Init
  4. Change MAINTENANCE_MODE to true
  5. Wait for pod to reboot
  6. Go to dev.drivebc.ca and confirm it shows the maintenance page. Also confirm no calls to the backend (this assumes backend is unavailable
  7. Reverse the change back to false and then refresh the page to confirm it shows dbc again.

Testing the Env variable change

  1. Open the index.html page
  2. Confirm that all the env variables are in the index.html file
  3. Confirm that all the site functionality still works as expected
  4. Run the site locally using npm start and confirm that it's also still working there as expected too

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

@bcgov-brwang bcgov-brwang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concerns about the environment variables that appear in the index scripts. Does this mean that those credentials could potentially be exposed?

@wmuldergov

Copy link
Copy Markdown
Collaborator Author

I have some concerns about the environment variables that appear in the index scripts. Does this mean that those credentials could potentially be exposed?

These are all public ones. If you go to the main.js in prod right now, you will see them at the very bottom. This just moves them to the index.html file which is not cached (unlike main.js which is). So in the case of env variable changes, users will now get them immediately instead of waiting for the cache to expire.

@bcgov-brwang
bcgov-brwang merged commit 3086ad2 into main Jun 2, 2026
23 of 24 checks passed
@ray-oxd
ray-oxd deleted the task/DBC22-6551 branch July 21, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants