Skip to content

DBC22-6431: auto open advisory panel on initial load with shared link - #1363

Merged
wmuldergov merged 2 commits into
mainfrom
bugfix/DBC22-6431
Jul 3, 2026
Merged

DBC22-6431: auto open advisory panel on initial load with shared link#1363
wmuldergov merged 2 commits into
mainfrom
bugfix/DBC22-6431

Conversation

@bcgov-brwang

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes/No)

    If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

  1. Deploy to dev.
  2. Create a route that passes through an Advisory.
  3. On the Routes panel, click "View Details".
  4. Click the Advisory item on Route details. The sidepanel for the advisory opens.
  5. Click "Share" and copy the link.
  6. Open the link in a new browser.
  7. Verify the receiver of the shared link sees the advisory within the route as if they created the route and then drilled down into Route details and clicked the Advisory themselves.

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

@bcgov-brwang
bcgov-brwang requested a review from wmuldergov June 3, 2026 21:40
@bcgov-brwang bcgov-brwang added the ready for review The PR is ready for review label Jun 3, 2026
@bcgov-brwang
bcgov-brwang marked this pull request as ready for review June 3, 2026 21:40
@wmuldergov

Copy link
Copy Markdown
Collaborator

The root issue seems to be fixed intermittently.
Here is the link: https://dev.drivebc.ca/?pan=-119.64523091004186%2C49.913305593647294&zoom=11.021495618472006&end=Kelowna%2C+BC&start=Merritt%2C+BC&type=advisory&id=193

If I copy that into:

  • Chrome (non incognito) - Works fine
  • Chrome (Incognito) - Works fine
  • Edge (incognito) - Opens fine, but if you then clikc <- Routes and try to click on any of the Advisory items, it doesn't open any of them.
  • Edge (non incognito) - Works fine
  • Mobile (Android Chrome non incognito) - Works fine
  • Mobile (Android Chrome Incognito) - Briefly loads the advisory and then goes back to the route A screen instead of displaying the Advisory

@bcgov-brwang

bcgov-brwang commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

The root issue seems to be fixed intermittently. Here is the link: https://dev.drivebc.ca/?pan=-119.64523091004186%2C49.913305593647294&zoom=11.021495618472006&end=Kelowna%2C+BC&start=Merritt%2C+BC&type=advisory&id=193

If I copy that into:

  • Chrome (non incognito) - Works fine
  • Chrome (Incognito) - Works fine
  • Edge (incognito) - Opens fine, but if you then clikc <- Routes and try to click on any of the Advisory items, it doesn't open any of them.
  • Edge (non incognito) - Works fine
  • Mobile (Android Chrome non incognito) - Works fine
  • Mobile (Android Chrome Incognito) - Briefly loads the advisory and then goes back to the route A screen instead of displaying the Advisory

For the third and last issue, I've completed the fix and verified that it works on my end. When you have a chance, could you please test it on your end and let me know if everything looks good?

DBC22-6431: auto open advisory panel on initial load with shared link

DBC22-6431: fix the issue when advisory clicked without response on routing detail panel

DBC22-6431: fix the issue when advisory clicked without response on routing detail panel - reverted

DBC22-6431: fixed left issues
@bcgov-brwang bcgov-brwang added ready for review The PR is ready for review pending rework If the PR needs some re-work by the developer and removed pending rework If the PR needs some re-work by the developer ready for review The PR is ready for review labels Jun 24, 2026
@wmuldergov
wmuldergov merged commit c071de0 into main Jul 3, 2026
12 of 13 checks passed
@wmuldergov
wmuldergov deleted the bugfix/DBC22-6431 branch July 3, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending rework If the PR needs some re-work by the developer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants