DBC22-6776: frontend implementation for grouping camera icons - #1385
Open
bcgov-brwang wants to merge 2 commits into
Open
DBC22-6776: frontend implementation for grouping camera icons#1385bcgov-brwang wants to merge 2 commits into
bcgov-brwang wants to merge 2 commits into
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
bcgov-brwang
force-pushed
the
feature/DBC22-6776
branch
2 times, most recently
from
July 2, 2026 15:11
36457bf to
50a4248
Compare
bcgov-brwang
force-pushed
the
feature/DBC22-6776
branch
from
July 8, 2026 18:34
f20f07b to
0814e34
Compare
bcgov-brwang
force-pushed
the
feature/DBC22-6776
branch
from
July 9, 2026 22:01
a66ba91 to
0797e75
Compare
bcgov-brwang
force-pushed
the
feature/DBC22-6776
branch
from
July 14, 2026 16:30
e4c8f77 to
b1f31c9
Compare
bcgov-brwang
changed the title
bcgov-brwang
marked this pull request as ready for review
July 14, 2026 16:37
bcgov-brwang
force-pushed
the
feature/DBC22-6776
branch
from
July 15, 2026 19:39
973f00b to
625edf8
Compare
|
draft 2 draft 3 draft 4 draft 5 draft 6 DBC22-6776: fixed broken test cases removed commented out code DBC22-6776: switch to fixed pixels to cluster icons DBC22-6776: removed variables not used DBC22-6776: updated grouped icons styling DBC22-6776: updated grouped icon text color DBC22-6776: updated text font in grouped icon DBC22-6776: fixed broken test case DBC22-6776: excluded index.js to void unit test canclling during Analysis progress DBC22-6776: fixed sonar scan alerts DBC22-6776: fixed sonar scan alerts part 2 DBC22-6776: single click on group icon takes user to next zoom level
ray-oxd
force-pushed
the
feature/DBC22-6776
branch
from
July 27, 2026 22:23
aae7d43 to
c056070
Compare
Collaborator
|
ray-oxd
reviewed
Jul 27, 2026
| updateReferenceFeature, | ||
| setLoadingLayers | ||
| setLoadingLayers, | ||
| 50 |
Collaborator
There was a problem hiding this comment.
what is this magic number here?
ray-oxd
reviewed
Jul 27, 2026
| if (size === 1) { | ||
| const cam = features[0]; | ||
| if (cam.get('clicked')) return cameraStyles.active; | ||
| if (cam.get('hovered')) return cameraStyles.hover; |
Collaborator
There was a problem hiding this comment.
are we missing unread cam stylings here?
ray-oxd
reviewed
Jul 27, 2026
| @@ -62,7 +121,11 @@ export function updateCamerasLayer(cameras, layer, setLoadingLayers) { | |||
| }, {}); | |||
|
|
|||
| for (const feature of layer.getSource().getFeatures()) { | |||
Collaborator
There was a problem hiding this comment.
This line might cease to work for grouped cameras but I've not tested this.
This may need to be
layer.getSource().getSource();
or
// Cluster source (what layer.getSource() returns now)
const clusterSource = layer.getSource();
// Real cameras — clustered or not, all of them live here
const cameraSource = clusterSource.getSource();
then use cameraSource instead.
ray-oxd
reviewed
Jul 27, 2026
|
|
||
| if (!clickedFeature.get('type')) { | ||
| clickedFeature = features[0].values_?.features[0]; | ||
| } |
Collaborator
There was a problem hiding this comment.
what is this repetition here? In addition, this whole block needs more comments on key operations
ray-oxd
reviewed
Jul 27, 2026
| } | ||
| catch { | ||
| feature.values_.features[0].setCameraStyle('static'); | ||
| } |
Collaborator
There was a problem hiding this comment.
the try/catchs here are workarounds, we should make sure we always have a feature instead (see comment regarding layer source)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Submitter
🔗 JIRA Ticket
✅ Quality Assurance & Requirements
⚙️ Configuration & Environment
🧪 How to Test (if required)
🔍 Reviewer Checklist