Loki + Promtail Memory Bump and other infrastructure tweaks - #194
Merged
Conversation
dbarkowsky
requested review from
NoorChasib,
alex-struk,
antsand and
kmandryk
as code owners
June 15, 2026 20:06
kmandryk
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've manually applied a lot of these changes to the TEST environment. Things seem to be stable. The only question is around whether Loki will continue to max out memory limits.
Changes
backend-servicesandtemporal-workerdeployments (request 32Mi → 64Mi, limit 64Mi → 128Mi) to prevent OOMKills caused by Loki backpressure filling the in-memory send queue.values-openshift.yaml, and ingestion rate limits (ingestion_rate_mb: 4,ingestion_burst_size_mb: 8) and ingester flush tuning added to the Loki config to apply back-pressure before memory is exhausted.ServiceAccount,Role(pods: get/list/watch), andRoleBindingfor Prometheus so Kubernetes SD configs no longer fail with apods is forbiddenerror against thedefaultservice account.lokiscrape job using a static target, enablingprocess_resident_memory_bytesand related queries to work.ches-notificationsandteams-notificationsare now gated onnotificationsEnabled, preventing an empty webhook URL from failing config validation when notifications are disabled.Deployment,Service,PodDisruptionBudget, logrotate and promtail ConfigMaps) are now gated onnotificationsEnabled, fixingInvalidImageNameerrors caused by rendering the deployment with an empty image repository.Recreateto preventMulti-Attacherrors on the RWO PVC when a rolling update starts a new pod before the old one terminates.Testing
Can check most of this until there is another PR merged that might overwrite it... then will have to check after this is merged.
PodInErrorStateorHighPodMemoryUsagealerts are firing in the test namespace.Checklist
By submitting this pull request, I acknowledge that I have attempted to meet the following: